Remove Redundant Delete from Shard Snapshot Delete #43569
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There is no point (and some harm) in deleting the snap- blob before writing the updated index-N blob in the shard folder: * We will delete it in `finalizeShard` anyway where we list the shard folders contents and clean them up * Deleting it before writing the updated index-N blob actually could leave a broken index-(N-1) blob if writing index-N fails and index-(N-1) still references the now deleted snap- blob
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
My bad, we don't yet clean up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finalizeShardanyway where we list the shard folders contents and clean them up (in a bulk delete) so we're just wasting an RPC call here