Remove guice modules from plugins #43555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guice modules provide a way to supply injected parameters to other injected constructors. The last remiaing use in plugins is to provide constructor arguments to transport actions. This commit removes the ability for plugins to provide guice modules. Any transport action parameters should be concretely typed and returned from createComponents, which are still injected. While this does not remove guice completely, it removes it from all remaining plugin apis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guice modules provide a way to supply injected parameters to other
injected constructors. The last remiaing use in plugins is to provide
constructor arguments to transport actions. This commit removes the
ability for plugins to provide guice modules. Any transport action
parameters should be concretely typed and returned from
createComponents, which are still injected. While this does not remove
guice completely, it removes it from all remaining plugin apis.