[ML][Data Frame] Add support for allow_no_match for endpoints #43490
Conversation
Adds support for: * Get Transforms * Get Transforms stats * stop transforms
|
Pinging @elastic/ml-core |
|
I suggest we drop the paradigm we followed for jobs and datafeeds and adopt |
|
@dimitris-athanasiou I am all for it. I will adjust this PR :) |
droberts195
changed the title
droberts195
left a comment
droberts195
left a comment
There was a problem hiding this comment.
There are a few places, admittedly not user facing, where the old names are still used. But for the sake of maintainers I think it would be nice to make all the names consistent.
|
|
||
| private final List<String> ids; | ||
| private PageParams pageParams; | ||
| private Boolean allowNoTransforms; |
There was a problem hiding this comment.
It would be less confusing to also rename the member variable.
| public class GetDataFrameTransformStatsRequest implements Validatable { | ||
| private final String id; | ||
| private PageParams pageParams; | ||
| private Boolean allowNoTransforms; |
There was a problem hiding this comment.
It would be less confusing to also rename the member variable.
| private final String id; | ||
| private Boolean waitForCompletion; | ||
| private TimeValue timeout; | ||
| private Boolean allowNoTransforms; |
There was a problem hiding this comment.
It would be less confusing to also rename the member variable.
| public static class Request extends BaseTasksRequest<Request> { | ||
| private final String id; | ||
| private PageParams pageParams = PageParams.defaultParams(); | ||
| private boolean allowNoResources = true; |
There was a problem hiding this comment.
Rename allowNoResources to allowNoMatch throughout this file, including the getter and setter.
| private final String id; | ||
| private final boolean waitForCompletion; | ||
| private final boolean force; | ||
| private final boolean allowNoResources; |
There was a problem hiding this comment.
Rename allowNoResources to allowNoMatch throughout this file, including the getter and setter.
|
@elasticmachine update branch |
…c#43490) * [ML][Data Frame] Add support for allow_no_match parameter in endpoints Adds support for: * Get Transforms * Get Transforms stats * stop transforms
5 participants
I opted for the name
allow_no_transformsin the APIs. This is for parity with ml jobs and datafeeds.The only peculiar endpoint is
_stats. If nothing is found, the current behavior is NOT to throw, but to return empty. Do we want to support this parameter in that API and do we want it to cause that endpoint to return a 404? I basically added the parameter, but it does not do much really.closes #42766