Testclusters: convert left-overs from checkPart1 #43370
Conversation
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
| autoSetInitialMasterNodes = false | ||
| autoSetHostsProvider = false | ||
| testClusters.integTest { | ||
| nameCustomization = { null } |
There was a problem hiding this comment.
Is there a way to do this in a more first-class way instead of using a null node name? The node name actually isn't relevant here. We just want to disable discovery. Perhaps we should make that a formal option on TestClusterConfiguration? We can then remove all the handling for null node names which is confusing IMO.
There was a problem hiding this comment.
We do also care about not configuring a node name for the test. We are also testing that we can start up without it. I taught about having a more formal way to do this, but this is the only test that would use it and it's a bit of an edge case.
Would definitely consider extending this if we were to have other users.
There was a problem hiding this comment.
Ah ok. I assumed the empty node name was just an implementation detail.
|
@mark-vieira are you ok with this PR now ? |
|
Yup 👍 |
* Testclusters: convert left-overs from checkPart1
4 participants
A few projects of checkPart1 were not converted. This PR closes that gap.