Optimize Azure Directory Delete #43341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
original-brownbear
commented
Jun 18, 2019
original-brownbear
commented
- Follow up to Recursive Delete on BlobContainer #43281:
- Optimizing the Azure directory delete operation:
- Same as with GCS and S3 we can simply flat list a prefix and then delete as we iterate instead of listing the directories recursively. This should require fewer actual list RPC calls and the logic becomes simpler
- Also reverted the added complexity for the normal bulk delete code that I had to add in Recursive Delete on BlobContainer #43281
* Follow up to elastic#43281: * Optimizing the Azure directory delete operation: * Same as with GCS and S3 we can simply flat list a prefix and then delete as we iterate instead of listing the directories recursively. This should require fewer actual list RPC calls and the logic becomes simpler
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
Jenkins run elasticsearch-ci/bwc |
ywelsch
suggested changes
Jul 1, 2019
.../repository-azure/src/main/java/org/elasticsearch/repositories/azure/AzureBlobContainer.java
Outdated
Show resolved
Hide resolved
.../repository-azure/src/main/java/org/elasticsearch/repositories/azure/AzureBlobContainer.java
Show resolved
Hide resolved
...repository-azure/src/main/java/org/elasticsearch/repositories/azure/AzureStorageService.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@ywelsch thanks for taking a look, removed the |
original-brownbear
added
backport pending
v7.4.0
and removed
v7.3.0
v7.4.0
backport pending
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.