Skip to content

Conversation

@mayya-sharipova
Copy link
Contributor

Do not allow custom analysis components to have the same names as
built-in components

Closes #22263

Do not allow custom analysis components to have the same names as
built-in components

Closes elastic#22263
@mayya-sharipova mayya-sharipova added the :Search Relevance/Analysis How text is split into tokens label Jun 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jpountz
Copy link
Contributor

jpountz commented Jun 17, 2019

I think we should still allow overriding the default, default_search and default_search_quoted analyzers, since this is the way that we document that default analyzers can be set at the index level? https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis.html

@mayya-sharipova
Copy link
Contributor Author

@jpountz Thanks for the feedback, Adrien. This has been addressed in the 2n commit.

@markharwood
Copy link
Contributor

@mayya-sharipova - a heads-up. I'm about to introduce the first out-of-the-box normalizer ("lowercase") in #53882

Like pre-built analyzers, pre-built normalizers should be something we want to avoid name-clashing with user-defined configurations in index settings.

@mayya-sharipova
Copy link
Contributor Author

@markharwood Thank you for the heads-up. I will adjust this PR accordingly

@mayya-sharipova
Copy link
Contributor Author

@markharwood I have decided that is better to tackle name clashing for normalizers in a separate PR, and normalizers are absent in PrebuiltAnalysis against which we checking name clashing. To put normalizers into PrebuiltAnalysis, we may need to introduce PreConfiguredNormalizer class and do some additional work.

@mayya-sharipova
Copy link
Contributor Author

@jpountz Can you please continue the review when you have time.

@rjernst rjernst added the Team:Search Meta label for search team label May 4, 2020
@arteam arteam added v8.1.0 and removed v8.0.0 labels Jan 12, 2022
@mark-vieira mark-vieira added v8.2.0 and removed v8.1.0 labels Feb 2, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @mayya-sharipova, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@javanna
Copy link
Member

javanna commented Feb 9, 2022

the changelog creation triggered notifcations on some of these old PRs, maybe it's a chance to close them though? :)

@elasticsearchmachine elasticsearchmachine changed the base branch from master to main July 22, 2022 23:14
@mark-vieira mark-vieira added v8.5.0 and removed v8.4.0 labels Jul 27, 2022
@quux00 quux00 added v8.11.0 and removed v8.10.0 labels Aug 16, 2023
@mattc58 mattc58 added v8.12.0 and removed v8.11.0 labels Oct 4, 2023
@javanna javanna added Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking :Search Relevance/Analysis How text is split into tokens Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not allow custom analyzers to have the same names as built-in analyzers