-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Custom analysis can't have same names as built-in #43252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Custom analysis can't have same names as built-in #43252
Conversation
Do not allow custom analysis components to have the same names as built-in components Closes elastic#22263
|
Pinging @elastic/es-search |
|
I think we should still allow overriding the |
|
@jpountz Thanks for the feedback, Adrien. This has been addressed in the 2n commit. |
|
@mayya-sharipova - a heads-up. I'm about to introduce the first out-of-the-box normalizer ("lowercase") in #53882 Like pre-built analyzers, pre-built normalizers should be something we want to avoid name-clashing with user-defined configurations in index settings. |
|
@markharwood Thank you for the heads-up. I will adjust this PR accordingly |
|
@markharwood I have decided that is better to tackle name clashing for normalizers in a separate PR, and normalizers are absent in |
|
@jpountz Can you please continue the review when you have time. |
|
Hi @mayya-sharipova, I've created a changelog YAML for you. Note that since this PR is labelled |
|
the changelog creation triggered notifcations on some of these old PRs, maybe it's a chance to close them though? :) |
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Do not allow custom analysis components to have the same names as
built-in components
Closes #22263