Add UnknownRole#equals, hashCode, toString #43227
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds methods to `DiscoveryNodeRole.UnknownRole` to compare these objects' values for equality, and adds a specialized `toString()` implementation for clearer test failures. Relates elastic#43175
DaveCTurner
added
:Core/Infra/Plugins
Collaborator
|
Pinging @elastic/es-core-infra |
jasontedor
reviewed
Jun 14, 2019
| "roleName='" + roleName() + '\'' + | ||
| ", roleAbbreviation='" + roleNameAbbreviation() + '\'' + | ||
| '}'; | ||
| } |
Member
There was a problem hiding this comment.
I think these can all go in the base class, as final, with adding getClass() to the toString implementation?
Contributor
Author
|
Closing in favour of #43257 |
DaveCTurner
deleted the
2019-06-14-DiscoveryNodeRole-UnknownRole-as-value-objects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods to
DiscoveryNodeRole.UnknownRoleto compare these objects'values for equality, and adds a specialized
toString()implementation forclearer test failures.
Relates #43175