Skip to content

[DOCS] Rewrite regexp query #42711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 24, 2019
Merged

[DOCS] Rewrite regexp query #42711

merged 11 commits into from
Jul 24, 2019

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented May 30, 2019

Changes

  • Rewrites description of regexp query
  • Breaks regular expression syntax section into separate page
  • Include all parameters in example request
  • Adds parameters sections

This is part of #40977, an effort to standardize documentation for query types.

Before

Regexp query - Before image Regexp query - Before image

After

Regexp query - After image Regexp query - After image
Regular expression syntax - After image Regular expression syntax - After image

@jrodewig jrodewig added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.2.0 v7.0.2 v7.1.2 labels May 30, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 30, 2019

Pinging @elastic/es-search

@jrodewig jrodewig mentioned this pull request May 30, 2019
Closed
62 tasks
@jrodewig jrodewig added the v6.8.1 label Jun 6, 2019
@jrodewig jrodewig removed the v6.8.2 label Jun 28, 2019
@jrodewig jrodewig added the v7.4.0 label Jul 3, 2019
@jpountz jpountz removed the v7.3.0 label Jul 3, 2019
mayya-sharipova
mayya-sharipova approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jrodewig

docs/reference/query-dsl/regexp-syntax.asciidoc Outdated
aa?bb? # no match

....
abc # matches 'ab', 'abb', 'abbb', 'abbbb', etc.
Copy link
Contributor

@mayya-sharipova mayya-sharipova Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be * instead of c?

Copy link
Contributor Author

@jrodewig jrodewig Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that @mayya-sharipova. Fixed with 19d387e.

@jrodewig jrodewig merged commit 8b2493c into elastic:master Jul 24, 2019
@jrodewig jrodewig deleted the regexp-query-rewrite branch July 24, 2019 12:37
jrodewig added a commit that referenced this pull request Jul 24, 2019
@jrodewig
[DOCS] Rewrite regexp query (#42711)
ad7c164
jrodewig added a commit that referenced this pull request Jul 24, 2019
@jrodewig
[DOCS] Rewrite regexp query (#42711)
0f85435
jrodewig added a commit that referenced this pull request Jul 24, 2019
@jrodewig
[DOCS] Rewrite regexp query (#42711)
fe6cb20
jrodewig added a commit that referenced this pull request Jul 24, 2019
@jrodewig
[DOCS] Rewrite regexp query (#42711)
b30b6a6
jrodewig added a commit that referenced this pull request Jul 24, 2019
@jrodewig
[DOCS] Rewrite regexp query (#42711)
4d0e61a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mayya-sharipova mayya-sharipova mayya-sharipova approved these changes

Assignees

No one assigned

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.2 v7.1.2 v7.4.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jrodewig @elasticmachine @mayya-sharipova @jpountz @jakelandis