Skip to content

Conversation

@pgomulka
Copy link
Contributor

Tests were failing in mixed cluster after more broad warnings were
introduced in 6.x These tests were using yyyy-MM-dd pattern which
is now warning about the change of y to u. However, using predefined pattern
strict_date which uses the same format prevents the warning from being
generate and allow smooth upgrade/work in mixed cluster.
relates #42679

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

Tests were failing in mixed cluster after more broad warnings were
introduced in 6.x These tests were using `yyyy-MM-dd` pattern which
is now warning about the change of `y` to `u`. However, using predefined pattern
`strict_date` which uses the same format prevents the warning from being
generate and allow smooth upgrade/work in mixed cluster.
relates elastic#42679
@pgomulka pgomulka added :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI labels May 30, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@pgomulka pgomulka self-assigned this May 30, 2019
@rjernst
Copy link
Member

rjernst commented May 30, 2019

This looks good, but in the future I don't think we need a separate PR for each branch. If a PR doesn't apply to master (ie is not something that could go through master), then it can target 7.x and be backported appropriately from there.

@pgomulka
Copy link
Contributor Author

@rjernst you are right, apologies. I aimed to create a PR for 7.x and backport to 7.2 and 7.1 but forgot about the appropriate labels

@pgomulka pgomulka requested review from rjernst and removed request for rjernst May 30, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport :Core/Infra/Core Core issues without another label >test-failure Triaged test failures from CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants