Small internal AnalysisRegistry changes #42500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some internal refactorings to the AnalysisRegistry, spin-off from elastic#40782.
cbuescher
added
>non-issue
:Search Relevance/Analysis
Collaborator
|
Pinging @elastic/es-search |
romseygeek
approved these changes
May 24, 2019
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, anything that makes this easier to read is a bonus
| final Map<String, TokenizerFactory> tokenizerFactories = buildTokenizerFactories(indexSettings); | ||
| final Map<String, TokenFilterFactory> tokenFilterFactories = buildTokenFilterFactories(indexSettings); | ||
| final Map<String, AnalyzerProvider<?>> analyzierFactories = buildAnalyzerFactories(indexSettings); | ||
| final Map<String, AnalyzerProvider<?>> analyzerFactories = buildAnalyzerFactories(indexSettings); |
cbuescher
pushed a commit
that referenced
this pull request
May 24, 2019
Some internal refactorings to the AnalysisRegistry, spin-off from #40782.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Some internal refactorings to the AnalysisRegistry, spin-off from elastic#40782.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some internal refactorings to the AnalysisRegistry, spin-off from #40782.
Mostly readability changes and reduction of some method sizes.