Skip to content

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented May 20, 2019

Secure settings currently error if they exist inside elasticsearch.yml.
This commit adds validation that non-secure settings do not exist inside
the keystore.

closes #41831

Secure settings currently error if they exist inside elasticsearch.yml.
This commit adds validation that non-secure settings do not exist inside
the keystore.

closes elastic#41831
@rjernst rjernst added >enhancement :Core/Infra/Core Core issues without another label v8.0.0 v7.2.0 labels May 20, 2019
@rjernst rjernst requested review from jasontedor and tvernum May 20, 2019 00:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jaymode jaymode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit da5abe2 into elastic:master May 20, 2019
@rjernst rjernst deleted the setting_validation branch May 20, 2019 18:35
rjernst added a commit that referenced this pull request May 20, 2019
Secure settings currently error if they exist inside elasticsearch.yml.
This commit adds validation that non-secure settings do not exist inside
the keystore.

closes #41831
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 20, 2019
…der-permit-primary-mode-only

* elastic/master:
  Validate non-secure settings are not in keystore (elastic#42209)
  Cleanup Various Uses of ActionListener (elastic#40126)
  Update api links per context (elastic#42033)
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Secure settings currently error if they exist inside elasticsearch.yml.
This commit adds validation that non-secure settings do not exist inside
the keystore.

closes elastic#41831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storing a non-secure setting in the keystore should prevent node start

5 participants