Skip to content

Fix grammar problem in stemming reference. #42148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2019
Merged

Fix grammar problem in stemming reference. #42148

merged 1 commit into from
May 22, 2019

Conversation

@swstepp
Copy link
Contributor

@swstepp swstepp commented May 14, 2019

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@tvernum tvernum added :Search Relevance/Analysis How text is split into tokens >docs General docs changes labels May 15, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 15, 2019

Pinging @elastic/es-search

@swstepp
Copy link
Contributor Author

swstepp commented May 22, 2019

Who has write access to merge this?

jtibshirani
jtibshirani approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swstepp for these corrections.

@jtibshirani
Copy link
Contributor

jtibshirani commented May 22, 2019

@elasticmachine test this please

@jtibshirani jtibshirani changed the title Fix grammar problem Fix grammar problem in stemming reference. May 22, 2019
@jtibshirani jtibshirani merged commit 943344f into elastic:master May 22, 2019
jtibshirani pushed a commit that referenced this pull request May 22, 2019
@swstepp @jtibshirani
Fix grammar problem in stemming reference. (#42148)
4181c5c
jtibshirani pushed a commit that referenced this pull request May 22, 2019
@swstepp @jtibshirani
Fix grammar problem in stemming reference. (#42148)
41b31d0
jtibshirani pushed a commit that referenced this pull request May 22, 2019
@swstepp @jtibshirani
Fix grammar problem in stemming reference. (#42148)
4634160
jtibshirani pushed a commit that referenced this pull request May 22, 2019
@swstepp @jtibshirani
Fix grammar problem in stemming reference. (#42148)
7317e5e
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 22, 2019
@jasontedor
Merge remote-tracking branch 'elastic/master' into remove-leftover-as…
a978312 
…sertion

* elastic/master:
  Make packer cache branches explicit (elastic#41990)
  Re-mute all ml_datafeed_crud rolling upgrade tests
  Ensure testAckedIndexing uses disruption index settings
  add 7_3 as version (elastic#42368)
  Fix grammar problem in stemming reference. (elastic#42148)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 22, 2019
@jasontedor
Merge remote-tracking branch 'elastic/master' into remove-deprecated-…
40010a3 
…search-remote-settings

* elastic/master:
  Make packer cache branches explicit (elastic#41990)
  Re-mute all ml_datafeed_crud rolling upgrade tests
  Ensure testAckedIndexing uses disruption index settings
  add 7_3 as version (elastic#42368)
  Fix grammar problem in stemming reference. (elastic#42148)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 22, 2019
@jasontedor
Merge remote-tracking branch 'elastic/master' into one-shard-leftover
29e3c66 
* elastic/master:
  Make packer cache branches explicit (elastic#41990)
  Re-mute all ml_datafeed_crud rolling upgrade tests
  Ensure testAckedIndexing uses disruption index settings
  add 7_3 as version (elastic#42368)
  Fix grammar problem in stemming reference. (elastic#42148)
jtibshirani pushed a commit that referenced this pull request May 22, 2019
@swstepp @jtibshirani
Fix grammar problem in stemming reference. (#42148)
81b9976
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@swstepp
Fix grammar problem in stemming reference. (elastic#42148)
3c3eacc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jtibshirani jtibshirani jtibshirani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport pending >docs General docs changes :Search Relevance/Analysis How text is split into tokens v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swstepp @elasticmachine @jtibshirani @jakelandis @tvernum