Reject port ranges in discovery.seed_hosts
#41905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today Elasticsearch accepts, but silently ignores, port ranges in the `discovery.seed_hosts` setting: ``` discovery.seed_hosts: 10.1.2.3:9300-9400 ``` Silently ignoring part of a setting like this is trappy. With this change we reject seed host addresses of this form. Closes elastic#40786 Backport of elastic#41404
DaveCTurner
added
>bug
>breaking
:Distributed Coordination/Cluster Coordination
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
Backport opened for a full CI run, no need to review. |
seut
added a commit
to crate/crate
that referenced
this pull request
May 14, 2019
seut
added a commit
to crate/crate
that referenced
this pull request
May 14, 2019
seut
added a commit
to crate/crate
that referenced
this pull request
May 14, 2019
seut
added a commit
to crate/crate
that referenced
this pull request
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today Elasticsearch accepts, but silently ignores, port ranges in the
discovery.seed_hostssetting:Silently ignoring part of a setting like this is trappy. With this change we
reject seed host addresses of this form.
Closes #40786
Backport of #41404