Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented May 6, 2019

Changes

  • Rewrites description of exists query
  • Adds top-level parameters section
  • Incorporates null_value field mapping note into parameter definition
  • Replaces missing query section with Find documents with null values section

This is part of #40977, an effort to standardize documentation for query types.

Any and all feedback welcome!

Before

Before image screencapture-elastic-co-guide-en-elasticsearch-reference-master-query-dsl-exists-query-html-2019-05-06-15_29_15

After

After image Screen Shot 2019-05-06 at 5 22 00 PM

@jrodewig jrodewig added :Search/Search Search-related issues that do not fall into other categories >docs General docs changes v7.0.2 v7.1.0 v7.2.0 v8.0.0 labels May 6, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit 49c9daa into elastic:master May 7, 2019
@jrodewig jrodewig deleted the exists-query-rewrite branch May 7, 2019 13:23
jrodewig added a commit that referenced this pull request May 7, 2019
jrodewig added a commit that referenced this pull request May 7, 2019
jrodewig added a commit that referenced this pull request May 7, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 7, 2019
* elastic/master: (50 commits)
  Cleanup versioned deprecations in analysis (elastic#41560)
  Allow unknown task time in QueueResizingEsTPE (elastic#41810)
  SQL: Remove CircuitBreaker from parser (elastic#41835)
  [DOCS] Fix callouts for dataframe APIs (elastic#41904)
  Handle serialization exceptions during publication (elastic#41781)
  Correct spelling of MockLogAppender.PatternSeenEventExpectation (elastic#41893)
  Update TLS ciphers and protocols for JDK 11 (elastic#41808)
  Remove Harmful Exists Check from BlobStoreFormat (elastic#41898)
  Fix fractional seconds for strict_date_optional_time (elastic#41871)
  Remove op.name configuration setting (elastic#41445)
  Reject port ranges in `discovery.seed_hosts` (elastic#41404)
  [ML-DataFrame] migrate to PageParams for get and stats, move PageParams into core (elastic#41851)
  Reenable RareClusterStateIT Mapping Propagation Tests (elastic#41884)
  [DOCS] Rewrite `exists` query docs (elastic#41868)
  Revert "Mute MinimumMasterNodesIT.testThreeNodesNoMasterBlock()"
  [DOCS] Fix typo referring to multi search API
  Provide names for all artifact repositories (elastic#41857)
  Move InternalAggregations to Writeable (elastic#41841)
  Fix compilation after incorrect merge
  Unmute TestClustersPluginIT.testMultiNode (elastic#41340)
  ...
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@jrodewig jrodewig added the v6.8.1 label Jun 6, 2019
jrodewig added a commit that referenced this pull request Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v6.8.1 v7.0.2 v7.1.0 v7.2.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants