Skip to content

Conversation

@jrodewig
Copy link
Contributor

@jrodewig jrodewig commented May 6, 2019

Replaces the parameters table for the ids query with a definition list. This should make ongoing maintenance easier. No substantive changes.

Before

Screen Shot 2019-05-06 at 3 15 49 PM

After

Screen Shot 2019-05-06 at 3 18 13 PM

@jrodewig jrodewig added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.0 :Docs v8.0.0 v7.2.0 v7.1.0 labels May 6, 2019
@jrodewig jrodewig requested review from debadair and kat257 May 6, 2019 19:22
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it seems more consistent with what we do in other query documentation.

@jrodewig jrodewig merged commit 731dac7 into elastic:master May 9, 2019
@jrodewig jrodewig deleted the replace-ids-query-table branch May 9, 2019 13:51
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.0 v7.1.0 v7.2.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants