Cut over SearchResponse and SearchTemplateResponse to Writeable #41855
Conversation
javanna
added
:Search/Search
|
Pinging @elastic/es-search |
| public SearchResponse() { | ||
| } | ||
|
|
||
| public SearchResponse(StreamInput in) throws IOException { |
There was a problem hiding this comment.
Can we also remove an empty constructor and make all member variables final here?
There was a problem hiding this comment.
yes this is not so hard so I am making this change.
| SearchTemplateResponse() { | ||
| } | ||
|
|
||
| SearchTemplateResponse(StreamInput in) throws IOException { |
There was a problem hiding this comment.
I wonder if we can remove an empty constructor and make all member variables final here? We may need to change a little fromXContent and have another constructor.
There was a problem hiding this comment.
this is possible yet it requires some work on how SearchTemplateResponse is used, as source and response are generally set after creation. I would prefer to keep this out of this PR.
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
Thanks @javanna! The PR looks good to me after we make changes SearchTemplateResponse.java and SearchResponse.java as outlined in the comments.
|
run elasticsearch-ci/bwc |
|
run elasticsearch-ci/docbldesx |
|
run elasticsearch-ci/1 |
4 participants
Relates to #34389