Add details to BulkShardRequest#getDescription() #41711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today a bulk shard request appears as follows in the detailed task list:
requests[42], index[my_index]
This change adds the shard index and refresh policy too:
requests[42], index[my_index][2], refresh[IMMEDIATE]
DaveCTurner
added
>enhancement
:Distributed Indexing/CRUD
dnhatn
reviewed
May 1, 2019
| return "requests[" + items.length + "], index[" + index + "]"; | ||
| final StringBuilder stringBuilder = new StringBuilder().append("requests[").append(items.length).append("], index").append(shardId); | ||
| final RefreshPolicy refreshPolicy = getRefreshPolicy(); | ||
| switch (refreshPolicy) { |
Member
There was a problem hiding this comment.
If might be simpler than switch here.
dnhatn
approved these changes
May 1, 2019
Member
dnhatn
left a comment
dnhatn
left a comment
There was a problem hiding this comment.
I left a minor comment but LGTM.
DaveCTurner
added a commit
that referenced
this pull request
May 2, 2019
Today a bulk shard request appears as follows in the detailed task list:
requests[42], index[my_index]
This change adds the shard index and refresh policy too:
requests[42], index[my_index][2], refresh[IMMEDIATE]
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
Today a bulk shard request appears as follows in the detailed task list:
requests[42], index[my_index]
This change adds the shard index and refresh policy too:
requests[42], index[my_index][2], refresh[IMMEDIATE]
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Today a bulk shard request appears as follows in the detailed task list:
requests[42], index[my_index]
This change adds the shard index and refresh policy too:
requests[42], index[my_index][2], refresh[IMMEDIATE]
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today a bulk shard request appears as follows in the detailed task list:
This change adds the shard index and refresh policy too: