Skip to content

Removes typed URLs from mapping APIs #41676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 23, 2019
Merged

Removes typed URLs from mapping APIs #41676

merged 15 commits into from
Sep 23, 2019

Conversation

@colings86
Copy link
Contributor

@colings86 colings86 commented Apr 30, 2019 •
edited
Loading

No description provided.

@colings86 colings86 added >breaking :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 labels Apr 30, 2019
@colings86 colings86 requested a review from jpountz April 30, 2019 10:48
@colings86 colings86 self-assigned this Apr 30, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 30, 2019

Pinging @elastic/es-search

@jpountz jpountz mentioned this pull request Apr 30, 2019
Closed
66 tasks
@colings86
Copy link
Contributor Author

colings86 commented May 20, 2019

@elasticmachine run elasticsearch-ci/packaging-sample

@colings86
Copy link
Contributor Author

colings86 commented May 23, 2019

@elasticmachine run elasticsearch-ci/default-distro

jpountz
jpountz suggested changes May 28, 2019
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some questions/comments.

@colings86
Copy link
Contributor Author

colings86 commented Jun 4, 2019

@elasticmachine run elasticsearch-ci/2

@colings86
Copy link
Contributor Author

colings86 commented Jun 10, 2019

@elasticmachine update branch

@colings86 colings86 requested a review from jpountz June 11, 2019 09:51
jpountz
jpountz approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry I let it wait for a review for so long.

@romseygeek romseygeek assigned romseygeek and unassigned colings86 Sep 12, 2019
@romseygeek
Copy link
Contributor

romseygeek commented Sep 23, 2019

@elasticmachine run elasticsearch-ci/docs-check

@romseygeek romseygeek merged commit a574a66 into elastic:master Sep 23, 2019
@jtibshirani jtibshirani mentioned this pull request Oct 1, 2019
Merged
@jtibshirani
Copy link
Contributor

jtibshirani commented Oct 2, 2019

@colings86 @romseygeek it looks like we removed many mixed typed/ typeless tests in this PR, such as indices.put_mapping/20_mix_typeless_typeful.yml. I wonder if we should restore/ repurpose a couple of these to make sure we have test coverage for typeless APIs against 7.x indices? In particular, we could test support for the following scenario:

  • A user creates an index in 7.x with a custom type like my_type.
  • The user upgrades to 8.x, then adds new mappings to the index using a typeless put mapping call.

@pgomulka pgomulka mentioned this pull request Mar 25, 2020
Closed
66 tasks
@pgomulka pgomulka mentioned this pull request Jul 8, 2020
Merged
pgomulka added a commit that referenced this pull request Jul 14, 2020
@pgomulka
Mappings get put and get mappings (#58426)
b09bd5a 
based on pgomulka:compat/delete_update #58246

CompatRestIT. test {yaml=indices.get_field_mapping/30_missing_type/Raise 404 when type doesn't exist}
because of that change (custom type to _doc) a test that was expecting 404 for a type that did not exist, passes now as the logic is trying to fetch for _doc (any type that exist on that index will be good).

CompatRestIT. test {yaml=indices.get_mapping/11_basic_with_types/Get /{index}/_mapping with empty mappings}
this is because I can't tell if the mapping contained a type or not when fetching a mapping.

CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Existent and non-existent type returns 404 and the existing type}
CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Existent and non-existent types returns 404 and the existing type}
CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/No type matching pattern returns 404}
CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Non-existent type returns 404}
failing - (not returning 404) - because type is always found (defaulted to _doc)

CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Type missing when no types exist}
CompatRestIT. test {yaml=indices.get_mapping/61_empty_with_types/Check empty mapping when getting all mappings via /_mapping}
CompatRestIT. test {yaml=indices.get_template/11_basic_with_types/Get template with no mappings}
CompatRestIT. test {yaml=indices.get_template/11_basic_with_types/Get template}
CompatRestIT. test {yaml=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with _doc on an index that has types}
CompatRestIT. test {yaml=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with typeless API on an index that has types}
#47364
#41676
@jakelandis jakelandis mentioned this pull request Feb 22, 2021
Closed
@pgomulka pgomulka mentioned this pull request Apr 19, 2021
Merged
pgomulka added a commit that referenced this pull request May 10, 2021
@pgomulka
[Rest API Compatibility] Typed endpoints for Put and Get Mapping and …
668a72d 
…get field mappings (#71721)

Implements a V7 compatible typed endpoints for REST put and get mapping endpoints. Also for Get Field Mappings endpoints.
retrofits the REST layer change removed in #41676

relates main meta issue #51816
relates types removal issue #54160
@masseyke masseyke mentioned this pull request Aug 9, 2021
Closed
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpountz jpountz jpountz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@romseygeek romseygeek

Labels

>breaking :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@colings86 @elasticmachine @romseygeek @jtibshirani @jpountz @jakelandis