-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[DOCS] Add anchors for Asciidoctor migration #41648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-docs |
Member
+1. I expect there are very few links to these anchors and those that exist will bounce to the page's heading instead which is OK. Not great, but ok. |
nik9000
approved these changes
Apr 30, 2019
Member
nik9000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsciiDoc and Asciidoctor use two separate conventions to autogenerate anchor IDs. When we migrate to Asciidoctor, this means several anchor links will break.
This explicitly sets anchor IDs for several sections and tables, which will create a stable anchor link during Asciidoctor migration.
Replaced IDs
List of IDs replaced
Remaining Autogenerated IDs
The ssl-settings.asciidoc file is included in several other files:
For each included file, separate IDs are created for ssl-settings.asciidoc heading. I couldn't figure out a way to explicitly set IDs for these sections without:
A. Breaking AsciiDoc
OR
B. Separating ssl-settings.asciidoc into multiple files for each heading
Option B didn't seem worth it due to increased complexity for maintaining the docs.
List of remaining autogenerated IDs
Backporting
I plan to backport as many changes as possible as far back as possible.