Deprecate support for first line empty in msearch API #41442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support for empty action metadata in the first msearch item, we need to remove support for prepending msearch request body with an empty line, which prevents us from parsing the empty line as action metadata for the first search item. Relates to elastic#41011
javanna
added
:Search/Search
Collaborator
|
Pinging @elastic/es-search |
jimczi
requested changes
Apr 23, 2019
| // support first line with \n | ||
| if (nextMarker == 0) { | ||
| from = nextMarker + 1; | ||
| deprecationLogger.deprecated("support for empty first line in msearch API is deprecated and will be removed"); |
Contributor
There was a problem hiding this comment.
I wonder if this is not misleading. In this version the first line is just ignored while in master we'll consider it as an empty action so I think that the message here should be more explicit.
Member
Author
There was a problem hiding this comment.
I agree it is misleading. yet I believe it will be regardless of the message that we come up with, because it is a weird change. we want to drop supporting an empty first line in case it does not represent an empty action metadata line, while we want to be able to support empty lines for action metadata lines in the first row
Member
Author
|
@jimczi I have revised the deprecation message, hopefully it is a bit clearer now. |
jimczi
approved these changes
Apr 24, 2019
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
Thanks for updating, LGTM
| if (nextMarker == 0) { | ||
| from = nextMarker + 1; | ||
| deprecationLogger.deprecated("support for empty first line before any action metadata in msearch API is deprecated and " + | ||
| "will be removed"); |
Contributor
There was a problem hiding this comment.
nit: will be removed in the next major version ?
javanna
added a commit
that referenced
this pull request
May 1, 2019
With #41442 we have deprecated support for empty line before any action metadata in msearch API. With this commit we remove support for such empty line, in place of parsing it as empty action metadata, which was previously not supported although the following items could have an empty line representing their corresponding action metadata. This way we make all times equal. Relates to #39841
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
With elastic#41442 we have deprecated support for empty line before any action metadata in msearch API. With this commit we remove support for such empty line, in place of parsing it as empty action metadata, which was previously not supported although the following items could have an empty line representing their corresponding action metadata. This way we make all times equal. Relates to elastic#39841
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
With elastic#41442 we have deprecated support for empty line before any action metadata in msearch API. With this commit we remove support for such empty line, in place of parsing it as empty action metadata, which was previously not supported although the following items could have an empty line representing their corresponding action metadata. This way we make all times equal. Relates to elastic#39841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support for empty action metadata in the first msearch item,
we need to remove support for prepending msearch request body with an
empty line, which prevents us from parsing the empty line as action
metadata for the first search item.
Relates to #41011