Skip to content

Conversation

@original-brownbear
Copy link
Contributor

This was fixed in #41332
but I forgot to reenable the test.

This was fixed in elastic#41332
but I forgot to reenable the test.
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.2.0 labels Apr 23, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@andrershov andrershov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@original-brownbear
Copy link
Contributor Author

Jenkins run elasticsearch-ci/1

3 similar comments
@original-brownbear
Copy link
Contributor Author

Jenkins run elasticsearch-ci/1

@original-brownbear
Copy link
Contributor Author

Jenkins run elasticsearch-ci/1

@original-brownbear
Copy link
Contributor Author

Jenkins run elasticsearch-ci/1

@original-brownbear
Copy link
Contributor Author

thanks @andrershov !

@original-brownbear original-brownbear merged commit f78834d into elastic:master Apr 24, 2019
@original-brownbear original-brownbear deleted the renable-snapshot-test branch April 24, 2019 13:44
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Apr 29, 2019
This was fixed in elastic#41332
but I forgot to reenable the test.
original-brownbear added a commit that referenced this pull request Apr 29, 2019
* Add Repository Consistency Assertion to SnapshotResiliencyTests (#40857)

* Add Repository Consistency Assertion to SnapshotResiliencyTests

* Add some quick validation on not leaving behind any dangling metadata or dangling indices to the snapshot resiliency tests
   * Added todo about expanding this assertion further

* Fix SnapshotResiliencyTest Repo Consistency Check (#41332)

* Fix SnapshotResiliencyTest Repo Consistency Check

* Due to the random creation of an empty `extra0` file by the Lucene mockFS we see broken tests because we use the existence of an index folder in assertions and the index deletion doesn't go through if there are extra files in an index folder
  * Fixed by removing the `extra0` file and resulting empty directory trees before asserting repo consistency
* Closes #41326

* Reenable SnapshotResiliency Test (#41437)

This was fixed in #41332
but I forgot to reenable the test.

* fix compile on java8
akhil10x5 pushed a commit to akhil10x5/elasticsearch that referenced this pull request May 2, 2019
This was fixed in elastic#41332
but I forgot to reenable the test.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
This was fixed in elastic#41332
but I forgot to reenable the test.
@original-brownbear original-brownbear restored the renable-snapshot-test branch August 6, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests v7.2.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants