SQL: Fix LIMIT bug in agg sorting #41258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying a limit over an agg sorting, the limit will be pushed down to the grouping which affects the custom sorting. This commit fixes that and restricts the limit only to sorting. Fix elastic#40984
Collaborator
|
Pinging @elastic/es-search |
astefan
approved these changes
Apr 16, 2019
Contributor
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
LGTM.
One small picky comment: if I'm not mistaken the query from the original issue is not in the tests? Indeed, there are many variants, but that specific one is not there, something like SELECT gender g, count(*) total FROM test_emp GROUP BY g ORDER BY total desc LIMIT 5.
Member
Author
|
@astefan no but it's one quite close to it: |
costin
added a commit
that referenced
this pull request
Apr 16, 2019
costin
added a commit
that referenced
this pull request
Apr 16, 2019
costin
added a commit
that referenced
this pull request
Apr 16, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
When specifying a limit over an agg sorting, the limit will be pushed down to the grouping which affects the custom sorting. This commit fixes that and restricts the limit only to sorting. Fix elastic#40984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying a limit over an agg sorting, the limit will be pushed
down to the grouping which affects the custom sorting. This commit fixes
that and restricts the limit only to sorting.
Fix #40984