Do not create missing directories in readonly repo #41249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we erroneously look for a node setting called `readonly` when deciding whether or not to create a missing directory in a filesystem repository. This change fixes this by using the repository setting instead. Closes elastic#41009 Relates elastic#26909
DaveCTurner
added
>bug
:Distributed Coordination/Snapshot/Restore
Collaborator
|
Pinging @elastic/es-distributed |
original-brownbear
approved these changes
Apr 16, 2019
Contributor
original-brownbear
left a comment
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM (assuming tests go green), left two suggestions :)
server/src/main/java/org/elasticsearch/common/blobstore/fs/FsBlobStore.java
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/repositories/fs/FsBlobStoreRepositoryIT.java
Outdated
Show resolved
Hide resolved
DaveCTurner
deleted the
2019-04-16-do-not-recreate-missing-directories-in-readonly-repos
branch
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Today we erroneously look for a node setting called `readonly` when deciding whether or not to create a missing directory in a filesystem repository. This change fixes this by using the repository setting instead. Closes elastic#41009 Relates elastic#26909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we erroneously look for a node setting called
readonlywhen decidingwhether or not to create a missing directory in a filesystem repository. This
change fixes this by using the repository setting instead.
Closes #41009
Relates #26909