Log every use of ILM Move to Step API #41171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage of the ILM Move to Step API can result in some very odd situations, and for diagnosing problems arising from these situations it would be nice to have a record of when this API was called with what parameters. Also, adds a dedicated logger for this class, rather than using the (deprecated) inherited one.
gwbrown
added
>non-issue
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-core-features |
dakrone
approved these changes
Apr 15, 2019
| new AckedClusterStateUpdateTask<Response>(request, listener) { | ||
| @Override | ||
| public ClusterState execute(ClusterState currentState) { | ||
| logger.info("moving index [{}] from [{}] to [{}]", |
Member
There was a problem hiding this comment.
Would it be possible for us to pull the policy name out here too and put it in? I think that might be nice
Contributor
Author
There was a problem hiding this comment.
In order to do this I needed to move the log statement to IndexLifecycleRuner#moveClusterStateToStep as we don't know the policy in the transport action. However, the javadoc for that method says that it's intended for moving steps in response to TransportAction executions, so I think it's fine to be there instead. That also lets us emit the logs after other checks (e.g. making sure the index is actually managed by any policy at all).
Member
There was a problem hiding this comment.
That's going to log a lot more often, since that's called for almost every step move, is that what we want?
Contributor
Author
There was a problem hiding this comment.
IndexLifecycleRuner#moveClusterStateToStep is only called via TransportMoveToStepAction and TransportRetryAction, I think you're thinking of IndexLifecycleRunner#moveClusterStateToNextStep.
Contributor
Author
There was a problem hiding this comment.
These method names could use a bit of work.
Member
There was a problem hiding this comment.
Yes, they definitely could, okay, I'm good with this where it is then :)
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Apr 15, 2019
Usage of the ILM Move to Step API can result in some very odd situations, and for diagnosing problems arising from these situations it would be nice to have a record of when this API was called with what parameters. Also, adds a dedicated logger for TransportMoveToStepAction, rather than using the (deprecated) inherited one.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Apr 15, 2019
Usage of the ILM Move to Step API can result in some very odd situations, and for diagnosing problems arising from these situations it would be nice to have a record of when this API was called with what parameters. Also, adds a dedicated logger for TransportMoveToStepAction, rather than using the (deprecated) inherited one.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Apr 15, 2019
Usage of the ILM Move to Step API can result in some very odd situations, and for diagnosing problems arising from these situations it would be nice to have a record of when this API was called with what parameters. Also, adds a dedicated logger for TransportMoveToStepAction, rather than using the (deprecated) inherited one.
gwbrown
added a commit
that referenced
this pull request
Apr 15, 2019
Usage of the ILM Move to Step API can result in some very odd situations, and for diagnosing problems arising from these situations it would be nice to have a record of when this API was called with what parameters. Also, adds a dedicated logger for TransportMoveToStepAction, rather than using the (deprecated) inherited one.
gwbrown
added a commit
that referenced
this pull request
Apr 15, 2019
Usage of the ILM Move to Step API can result in some very odd situations, and for diagnosing problems arising from these situations it would be nice to have a record of when this API was called with what parameters. Also, adds a dedicated logger for TransportMoveToStepAction, rather than using the (deprecated) inherited one.
gwbrown
added a commit
that referenced
this pull request
Apr 15, 2019
Usage of the ILM Move to Step API can result in some very odd situations, and for diagnosing problems arising from these situations it would be nice to have a record of when this API was called with what parameters. Also, adds a dedicated logger for TransportMoveToStepAction, rather than using the (deprecated) inherited one.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Usage of the ILM Move to Step API can result in some very odd situations, and for diagnosing problems arising from these situations it would be nice to have a record of when this API was called with what parameters. Also, adds a dedicated logger for TransportMoveToStepAction, rather than using the (deprecated) inherited one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of the ILM Move to Step API can result in some very odd
situations, and for diagnosing problems arising from these situations it
would be nice to have a record of when this API was called with what
parameters.
Also, adds a dedicated logger for this class, rather than using the
(deprecated) inherited one.