Increase maximum forecast interval to 10 years. #41082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/ml-core |
przemekwitek
force-pushed
the
maximum_forecast_interval
branch
from
d753e78 to
49b7991
Compare
hendrikmuhs
approved these changes
Apr 11, 2019
hendrikmuhs
left a comment
hendrikmuhs
left a comment
There was a problem hiding this comment.
LGTM technically, we should ensure the kibana change lands on the same version if this goes in
That's a nice-to-have, but not critical. We can build up the layers as time goes by. |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Increase the maximum duration to ~10 years (3650 days).
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
May 30, 2019
Increase the maximum duration to ~10 years (3650 days).
przemekwitek
added a commit
that referenced
this pull request
May 30, 2019
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
May 30, 2019
Increase the maximum duration to ~10 years (3650 days).
przemekwitek
added a commit
that referenced
this pull request
May 31, 2019
Merged
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase maximum forecast interval from 8 weeks (56 days) to ~10 years (3650 days).
Add a YML test for the validation being modified.
Closes #41103