SQL: Small code improvements of Pipes & Processors #40909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matriv
commented
Apr 5, 2019
matriv
commented
- Remove superfluous methods that are already defined in superclasses.
- Improve tests for null folding on conditionals
- Remove superfluous methods that are already defined in superclasses. - Improve tests for null folding on conditionals
Collaborator
|
Pinging @elastic/es-search |
costin
approved these changes
Apr 7, 2019
| } | ||
|
|
||
| return false; | ||
| return children().stream().anyMatch(Pipe::supportedByAggsOnlyQuery); |
matriv
added a commit
that referenced
this pull request
Apr 8, 2019
- Remove superfluous methods that are already defined in superclasses. - Improve tests for null folding on conditionals (cherry picked from commit 67f9404)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
- Remove superfluous methods that are already defined in superclasses. - Improve tests for null folding on conditionals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.