Fix put mapping authorization for aliases with a write-index and multiple read indices #40834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When same alias points to multiple indices we can write to only one index with `is_write_index` value `true`. The special handling in case of put mapping request to resolve authorized indices had a check on indices size. If multiple indices existed then it marks request unauthorized. The check has been modified to consider write index flag and only when the requested index matches with the one with write index alias. Closes elastic#40831
bizybot
added
>bug
v7.0.0
:Security/Authorization
Collaborator
|
Pinging @elastic/es-security |
bizybot
commented
Apr 4, 2019
...security/src/main/java/org/elasticsearch/xpack/security/authz/IndicesAndAliasesResolver.java
Show resolved
Hide resolved
tvernum
reviewed
Apr 5, 2019
...security/src/main/java/org/elasticsearch/xpack/security/authz/IndicesAndAliasesResolver.java
Show resolved
Hide resolved
...security/src/main/java/org/elasticsearch/xpack/security/authz/IndicesAndAliasesResolver.java
Show resolved
Hide resolved
...security/src/main/java/org/elasticsearch/xpack/security/authz/IndicesAndAliasesResolver.java
Outdated
Show resolved
Hide resolved
...ity/src/test/java/org/elasticsearch/xpack/security/authz/IndicesAndAliasesResolverTests.java
Outdated
Show resolved
Hide resolved
...ity/src/test/java/org/elasticsearch/xpack/security/authz/IndicesAndAliasesResolverTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/test/security/authz/32_ilm_using_alias.yml
Outdated
Show resolved
Hide resolved
added 2 commits
April 7, 2019 16:31
- Split unit test with clear purpose - Move to integ tests instead of rest api test - filter authorized indices before other tests in resolver
Contributor
Author
|
Hi @talevy, I have added a new test case in PermissionsIT. I see you last worked on PermissionsIT. |
talevy
reviewed
Apr 10, 2019
...lugin/ilm/qa/with-security/src/test/java/org/elasticsearch/xpack/security/PermissionsIT.java
Outdated
Show resolved
Hide resolved
talevy
reviewed
Apr 10, 2019
...lugin/ilm/qa/with-security/src/test/java/org/elasticsearch/xpack/security/PermissionsIT.java
Show resolved
Hide resolved
added 2 commits
April 10, 2019 12:37
talevy
approved these changes
Apr 10, 2019
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 |
albertzaharovits
approved these changes
Apr 11, 2019
Contributor
albertzaharovits
left a comment
albertzaharovits
left a comment
There was a problem hiding this comment.
LGTM, sorry for the delay!
I suggest when merging to change the name of the commit/PR, to something more representative such as: "put mapping authorization for aliases with write-index"
Contributor
Author
|
Hi @tvernum I have addressed your review comments, please review when you get some time. Thank you. |
tvernum
approved these changes
Apr 15, 2019
Contributor
tvernum
left a comment
tvernum
left a comment
There was a problem hiding this comment.
LGTM, but I have 1 suggestion.
...security/src/main/java/org/elasticsearch/xpack/security/authz/IndicesAndAliasesResolver.java
Outdated
Show resolved
Hide resolved
bizybot
changed the title
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Apr 17, 2019
…d indices (elastic#40834) When the same alias points to multiple indices we can write to only one index with `is_write_index` value `true`. The special handling in case of the put mapping request(to resolve authorized indices) has a check on indices size for a concrete index. If multiple indices existed then it marked the request as unauthorized. The check has been modified to consider write index flag and only when the requested index matches with the one with write index alias, the alias is considered for authorization. Closes elastic#40831
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Apr 17, 2019
…d indices (elastic#40834) When the same alias points to multiple indices we can write to only one index with `is_write_index` value `true`. The special handling in case of the put mapping request(to resolve authorized indices) has a check on indices size for a concrete index. If multiple indices existed then it marked the request as unauthorized. The check has been modified to consider write index flag and only when the requested index matches with the one with write index alias, the alias is considered for authorization. Closes elastic#40831
bizybot
added a commit
that referenced
this pull request
Apr 17, 2019
…d indices (#40834) (#41288) When the same alias points to multiple indices we can write to only one index with `is_write_index` value `true`. The special handling in case of the put mapping request(to resolve authorized indices) has a check on indices size for a concrete index. If multiple indices existed then it marked the request as unauthorized. The check has been modified to consider write index flag and only when the requested index matches with the one with write index alias, the alias is considered for authorization. Closes #40831
bizybot
added a commit
that referenced
this pull request
Apr 17, 2019
…d indices (#40834) (#41287) When the same alias points to multiple indices we can write to only one index with `is_write_index` value `true`. The special handling in case of the put mapping request(to resolve authorized indices) has a check on indices size for a concrete index. If multiple indices existed then it marked the request as unauthorized. The check has been modified to consider write index flag and only when the requested index matches with the one with write index alias, the alias is considered for authorization. Closes #40831
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Apr 17, 2019
…d indices (elastic#40834) When the same alias points to multiple indices we can write to only one index with `is_write_index` value `true`. The special handling in case of the put mapping request(to resolve authorized indices) has a check on indices size for a concrete index. If multiple indices existed then it marked the request as unauthorized. The check has been modified to consider write index flag and only when the requested index matches with the one with write index alias, the alias is considered for authorization. Closes elastic#40831
bizybot
added a commit
that referenced
this pull request
Apr 17, 2019
…d indices (#40834) (#41289) When the same alias points to multiple indices we can write to only one index with `is_write_index` value `true`. The special handling in case of the put mapping request(to resolve authorized indices) has a check on indices size for a concrete index. If multiple indices existed then it marked the request as unauthorized. The check has been modified to consider write index flag and only when the requested index matches with the one with write index alias, the alias is considered for authorization. Closes #40831
jaymode
changed the title
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…d indices (elastic#40834) When the same alias points to multiple indices we can write to only one index with `is_write_index` value `true`. The special handling in case of the put mapping request(to resolve authorized indices) has a check on indices size for a concrete index. If multiple indices existed then it marked the request as unauthorized. The check has been modified to consider write index flag and only when the requested index matches with the one with write index alias, the alias is considered for authorization. Closes elastic#40831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the same alias points to multiple indices we can write to only one index
with
is_write_indexvaluetrue. The special handling in case of the putmapping request(to resolve authorized indices) has a check on indices size
for a concrete index. If multiple indices existed then it marked the request
as unauthorized.
The check has been modified to consider write index flag and only when the
requested index matches with the one with write index alias, the alias is considered
for authorization.
Closes #40831