-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Bump the minimum Java version to Java 11 #40754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b012e02
64a31b1
4679b61
f4a7816
b37935e
889cf14
2842b9b
795cbc6
845d9ab
ecfcf7a
c932ca7
e3953c2
50dba05
9c2bfbb
e9317be
e90b710
1c7e299
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -246,6 +246,10 @@ def linux_common(config, | |
| touch /is_vagrant_vm # for consistency between linux and windows | ||
| SHELL | ||
|
|
||
| config.vm.provision 'jdk-11', type: 'shell', inline: <<-SHELL | ||
| curl -sSL https://download.java.net/java/GA/jdk11/9/GPL/openjdk-11.0.2_linux-x64_bin.tar.gz | tar xz -C /opt/ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can potentially lead to more CI failures due to network issues.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need a non-bundled JDK in the image that can run Elasticsearch to test that a non-bundled JDK works. The installed JDK 8s would be too old, so we need JDK 11. |
||
| SHELL | ||
|
|
||
| # This prevents leftovers from previous tests using the | ||
| # same VM from messing up the current test | ||
| config.vm.provision 'clean es installs in tmp', run: 'always', type: 'shell', inline: <<-SHELL | ||
|
|
@@ -342,7 +346,7 @@ def sh_install_deps(config, | |
| } | ||
| cat \<\<JAVA > /etc/profile.d/java_home.sh | ||
| if [ -z "\\\$JAVA_HOME" ]; then | ||
| export JAVA_HOME=$(dirname $(dirname $(readlink -f $(which java)))) | ||
| export JAVA_HOME=/opt/jdk-11.0.2 | ||
| fi | ||
| export SYSTEM_JAVA_HOME=\\\$JAVA_HOME | ||
| unset JAVA_HOME | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.12 | ||
| 12 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.8 | ||
| 11 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| [float] | ||
| [[breaking_80_packaging_changes]] | ||
| === Packaging changes | ||
|
|
||
| [float] | ||
| //tag::notable-breaking-changes[] | ||
| ==== Java 11 is required | ||
|
|
||
| Java 11 or higher is now required to run Elasticsearch and any of its command | ||
| line tools. | ||
| //end::notable-breaking-changes[] |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we have an alternative before removing this?
There's #37250 so this will not fall trough the cracks, but in the interim we will have no fips testing,
and fips might have to play catch-up once we get the tests back.
I think that's something we should generally try to avoid in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discussed this with @jkakavas and he will be working on getting a FIPS-compliant JDK 11 ready, but agreed that can happen independently. He will focus on that in the upcoming week.