Skip to content

POC: Use multiple index commits to retain soft-deleted documents #40671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

POC: Use multiple index commits to retain soft-deleted documents #40671

wants to merge 3 commits into from

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Apr 1, 2019

This PoC uses multiple index commits (with SoftDeletesRetentionMergePolicy) to retain soft-deleted documents. This change merely adjusts the index deletion policy and changes snapshot. We need to adopt this change in recovery.

@dnhatn dnhatn added WIP :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. labels Apr 1, 2019
@dnhatn dnhatn requested review from bleskes, jpountz and s1monw April 1, 2019 02:43
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 1, 2019

Pinging @elastic/es-distributed

@dnhatn dnhatn changed the title POC: Use multiple index commits to retain soft-del documents POC: Use multiple index commits to retain soft-deleted documents Apr 1, 2019
@dnhatn
Copy link
Member Author

dnhatn commented Jun 4, 2019

I am closing this PR in favor of #40741 for these reasons:

  • This approach requires a lot of work on the recovery code
  • Peer recovery or even a store recovery might have to replay a lot of translog with this approach
  • Search with multiple index commits is not easy since we have to deal with duplicates

@dnhatn dnhatn closed this Jun 4, 2019
@dnhatn dnhatn deleted the multi-commits branch June 26, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpountz jpountz Awaiting requested review from jpountz

@s1monw s1monw Awaiting requested review from s1monw

@bleskes bleskes Awaiting requested review from bleskes

Assignees

No one assigned

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. WIP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dnhatn @elasticmachine