SQL: Implement CURRENT_TIME/CURTIME functions #40662
Conversation
|
Pinging @elastic/es-search |
|
Needs to wait for #39802 and be rebased on top. |
There was a problem hiding this comment.
This should be a NOTE: or WARNING:
There was a problem hiding this comment.
We don't use them in the limitations page. In the grouping.asciidoc there is and IMPORTANT paragraph mentioning the same limitation.
There was a problem hiding this comment.
An alternative is to move these tests back to the docs.csv-spec and mark them as -Ignore which means they will not be ran.
After `TIME` SQL data type is introduced, implement `CURRENT_TIME/CURTIME` functions similar to CURRENT_TIMESTAMP that return the system's current time (only, without the date part). Closes: elastic#40468
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
LGTM. Left few comments regarding the documentation.
| -------------------------------------------------- | ||
|
|
||
| ["source","sql",subs="attributes,callouts,macros"] | ||
| -------------------------------------------------- |
There was a problem hiding this comment.
Twice the same query? (see above)
There was a problem hiding this comment.
Should be an example for CURTIME, fixing it.
| [source, sql] | ||
| -------------------------------------------------- | ||
| CURRENT_TIME | ||
| CURRENT_TIME(precision <1>) |
There was a problem hiding this comment.
I thought we were using the CURRENT_TIME([precision <1>]) (square brackets) for optional parameters, but looking at CURRENT_TIMESTAMP I see the same approach. Other functions (ROUND, TRUNCATE and few string functions) use the square brackets format.
There was a problem hiding this comment.
Adding the square brackets, will also fix it for CURRENT_TIMESTAMP with a separate PR.
| -------------------------------------------------- | ||
|
|
||
| [IMPORTANT] | ||
| Currently, Using a _precision_ greater than 3 doesn't make any difference to the output of the |
After `TIME` SQL data type is introduced, implement `CURRENT_TIME/CURTIME` functions similarly to CURRENT_TIMESTAMP that return the system's current time (only, without the date part). Closes: elastic#40468
5 participants
After
TIMESQL data type is introduced, implementCURRENT_TIME/CURTIMEfunctions similar to CURRENT_TIMESTAMPthat return the system's current time (only, without the date part).
Closes: #40648