Skip to content

SQL: Centralize SQL test dependencies version handling #40551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2019
Merged

SQL: Centralize SQL test dependencies version handling #40551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x-pack/plugin/sql/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ ext {
// SQL dependency versions
jlineVersion="3.10.0"
antlrVersion="4.5.3"

// SQL test dependency versions
csvjdbcVersion="1.0.34"
h2Version="1.4.197"
}

configurations {
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugin/sql/qa/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies {
compile project(path: xpackModule('sql:jdbc'), configuration: 'nodeps')

compile project(path: xpackModule('sql:sql-action'))
compile "net.sourceforge.csvjdbc:csvjdbc:1.0.34"
compile "net.sourceforge.csvjdbc:csvjdbc:${csvjdbcVersion}"

// CLI testing dependencies
compile project(path: xpackModule('sql:sql-cli'), configuration: 'nodeps')
Expand Down Expand Up @@ -54,8 +54,8 @@ subprojects {
testCompile "org.elasticsearch.test:framework:${version}"

// JDBC testing dependencies
testRuntime "net.sourceforge.csvjdbc:csvjdbc:1.0.34"
testRuntime "com.h2database:h2:1.4.197"
testRuntime "net.sourceforge.csvjdbc:csvjdbc:${csvjdbcVersion}"
testRuntime "com.h2database:h2:${h2Version}"
testRuntime project(path: xpackModule('sql:jdbc'), configuration: 'nodeps')
testRuntime xpackProject('plugin:sql:sql-client')

Expand Down