Skip to content

Conversation

@jasontedor
Copy link
Member

This commit adds the Oracle JDK 12 and the Zulu JDK 12 distributions to testing.

This commit adds the Oracle JDK 12 and the Zulu JDK 12 distributions to
testing.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@mark-vieira
Copy link
Contributor

Isn't openjdk and the oraclejdk in this case basically identical except for licensing?

@jasontedor
Copy link
Member Author

Isn't openjdk and the oraclejdk in this case basically identical except for licensing?

Mostly yes, but it costs us almost nothing to run two builds a day to help with our efforts to claim support of the Oracle commercially-licensed JDK.

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor jasontedor merged commit 56b08eb into elastic:master Mar 26, 2019
jasontedor added a commit that referenced this pull request Mar 26, 2019
This commit adds the Oracle JDK 12 and the Zulu JDK 12 distributions to
testing.
jasontedor added a commit that referenced this pull request Mar 26, 2019
This commit adds the Oracle JDK 12 and the Zulu JDK 12 distributions to
testing.
jasontedor added a commit that referenced this pull request Mar 26, 2019
This commit adds the Oracle JDK 12 and the Zulu JDK 12 distributions to
testing.
@jasontedor jasontedor deleted the more-java-12s branch March 26, 2019 22:50
@alpar-t
Copy link
Contributor

alpar-t commented Mar 27, 2019

LGTM @jasontedor can you please update .ci/packer_cache.sh with s/java12/openjdk12 to avoid confusion.
The packer cache script used to fail because of this but will now work due to changes in CI related to this PR.

@alpar-t
Copy link
Contributor

alpar-t commented Mar 27, 2019

Disregard the previous comment. I opened #40498 somehow missed that this PR was already merged.

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants