Skip to content

Use Correct Enum in Wipe Snapshots Test Method #40422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2019
Merged

Use Correct Enum in Wipe Snapshots Test Method #40422

merged 1 commit into from
Mar 26, 2019

Conversation

@original-brownbear
Copy link
Contributor

@original-brownbear original-brownbear commented Mar 25, 2019

  • Mistake was made in Wipe Snapshots Before Indices in RestTests #39662
  • The response deserialized here is org.elasticsearch.action.admin.cluster.snapshots.get.GetSnapshotsResponse which uses org.elasticsearch.snapshots.SnapshotInfo which uses org.elasticsearch.snapshots.SnapshotState and not the shard state

thanks for finding this @dakrone

@original-brownbear
Use Correct Enum in Wipe Snapshots Test Method
9a95659 
* Mistake was made in elastic#39662
* The response deserialized here is `org.elasticsearch.action.admin.cluster.snapshots.get.GetSnapshotsResponse` which uses `org.elasticsearch.snapshots.SnapshotInfo` which uses `org.elasticsearch.snapshots.SnapshotState` and not the shard state
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.0.0 v8.0.0 v7.2.0 v6.7.1 labels Mar 25, 2019
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 25, 2019

Pinging @elastic/es-distributed

dakrone
dakrone approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Armin

DaveCTurner
DaveCTurner approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. LGTM.

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Mar 25, 2019

Jenkins test this

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Mar 25, 2019

Jenkins run elasticsearch-ci/bwc

@dakrone
Copy link
Member

dakrone commented Mar 25, 2019

@elasticmachine run elasticsearch-ci/bwc

@original-brownbear
Copy link
Contributor Author

original-brownbear commented Mar 26, 2019

thanks @dakrone and @DaveCTurner !

@original-brownbear original-brownbear merged commit da23c89 into elastic:master Mar 26, 2019
@original-brownbear original-brownbear deleted the fix-wrong-enum-in-test branch March 26, 2019 06:04
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Mar 26, 2019
@original-brownbear
Use Correct Enum in Wipe Snapshots Test Method (elastic#40422)
5314181 
* Mistake was made in elastic#39662
* The response deserialized here is `org.elasticsearch.action.admin.cluster.snapshots.get.GetSnapshotsResponse` which uses `org.elasticsearch.snapshots.SnapshotInfo` which uses `org.elasticsearch.snapshots.SnapshotState` and not the shard state
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Mar 26, 2019
@original-brownbear
Use Correct Enum in Wipe Snapshots Test Method (elastic#40422)
5c9036a 
* Mistake was made in elastic#39662
* The response deserialized here is `org.elasticsearch.action.admin.cluster.snapshots.get.GetSnapshotsResponse` which uses `org.elasticsearch.snapshots.SnapshotInfo` which uses `org.elasticsearch.snapshots.SnapshotState` and not the shard state
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Mar 26, 2019
@original-brownbear
Use Correct Enum in Wipe Snapshots Test Method (elastic#40422)
df120fd 
* Mistake was made in elastic#39662
* The response deserialized here is `org.elasticsearch.action.admin.cluster.snapshots.get.GetSnapshotsResponse` which uses `org.elasticsearch.snapshots.SnapshotInfo` which uses `org.elasticsearch.snapshots.SnapshotState` and not the shard state
original-brownbear added a commit that referenced this pull request Mar 26, 2019
@original-brownbear
Use Correct Enum in Wipe Snapshots Test Method (#40422) (#40440)
1ee0ca3 
* Mistake was made in #39662
* The response deserialized here is `org.elasticsearch.action.admin.cluster.snapshots.get.GetSnapshotsResponse` which uses `org.elasticsearch.snapshots.SnapshotInfo` which uses `org.elasticsearch.snapshots.SnapshotState` and not the shard state
original-brownbear added a commit that referenced this pull request Mar 26, 2019
@original-brownbear
Use Correct Enum in Wipe Snapshots Test Method (#40422) (#40439)
f1edfa3 
* Mistake was made in #39662
* The response deserialized here is `org.elasticsearch.action.admin.cluster.snapshots.get.GetSnapshotsResponse` which uses `org.elasticsearch.snapshots.SnapshotInfo` which uses `org.elasticsearch.snapshots.SnapshotState` and not the shard state
original-brownbear added a commit that referenced this pull request Mar 26, 2019
@original-brownbear
Use Correct Enum in Wipe Snapshots Test Method (#40422) (#40438)
cafb832 
* Mistake was made in #39662
* The response deserialized here is `org.elasticsearch.action.admin.cluster.snapshots.get.GetSnapshotsResponse` which uses `org.elasticsearch.snapshots.SnapshotInfo` which uses `org.elasticsearch.snapshots.SnapshotState` and not the shard state
@original-brownbear original-brownbear restored the fix-wrong-enum-in-test branch August 6, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dakrone dakrone dakrone approved these changes

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests v6.7.1 v7.0.0-rc2 v7.2.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@original-brownbear @elasticmachine @dakrone @DaveCTurner @jakelandis