Prevent slow field lookups when JSON fields are present. #39872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>enhancement
:Search Foundations/Mapping
Collaborator
|
Pinging @elastic/es-search |
romseygeek
approved these changes
Mar 11, 2019
Contributor
romseygeek
left a comment
romseygeek
left a comment
There was a problem hiding this comment.
LGTM. It would be nice to try and test the short-circuit behaviour, but there isn't really any way to determine if it has kicked in or not, so I'm fine with the tests as they are.
jtibshirani
force-pushed
the
object-fields
branch
from
8f1a4dc to
28d42e9
Compare
jtibshirani
force-pushed
the
field-type-lookup
branch
from
e415219 to
2591624
Compare
jtibshirani
force-pushed
the
object-fields
branch
from
28d42e9 to
cdaf8e4
Compare
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
jtibshirani
force-pushed
the
field-type-lookup
branch
from
2591624 to
22a8d53
Compare
Contributor
Author
|
Thanks @romseygeek for the review! I had to fix some test issues in the base branch |
11 tasks
jtibshirani
added a commit
that referenced
this pull request
Mar 14, 2019
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
jtibshirani
added a commit
that referenced
this pull request
Mar 19, 2019
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
jtibshirani
added a commit
to jtibshirani/elasticsearch
that referenced
this pull request
Mar 19, 2019
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
jtibshirani
added a commit
that referenced
this pull request
Mar 28, 2019
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
jtibshirani
added a commit
that referenced
this pull request
Apr 10, 2019
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
jtibshirani
added a commit
that referenced
this pull request
Apr 17, 2019
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
jtibshirani
added a commit
that referenced
this pull request
May 1, 2019
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
jtibshirani
added a commit
that referenced
this pull request
May 24, 2019
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
jtibshirani
added a commit
that referenced
this pull request
May 29, 2019
We now track the maximum depth of any JSON field, which allows the JSON field lookup to be short-circuited as soon as that depth is reached. This helps prevent slow lookups when the user is searching over a very deep field that is not in the mappings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now track the maximum depth of any JSON field, which allows the JSON field
lookup to be short-circuited as soon as that depth is reached. This helps
prevent slow lookups when the user is searching over a very deep field that is
not in the mappings.