SQL: values in datetime script aggs should be treated as long #39773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-search |
When a query is translated into script terms agg where key has a date type, it should generate a terms agg with value_type long instead of date, otherwise the key gets formatted as a string, which confuses hit extractor. Fixes elastic#37042
imotov
force-pushed
the
issue-37042-date-in-key-extractor
branch
from
014ccd9 to
1721716
Compare
imotov
added a commit
that referenced
this pull request
Mar 11, 2019
When a query is translated into script terms agg where key has a date type, it should generate a terms agg with value_type long instead of date, otherwise the key gets formatted as a string, which confuses hit extractor. Fixes #37042
imotov
added a commit
that referenced
this pull request
Mar 11, 2019
When a query is translated into script terms agg where key has a date type, it should generate a terms agg with value_type long instead of date, otherwise the key gets formatted as a string, which confuses hit extractor. Fixes #37042
imotov
added a commit
that referenced
this pull request
Mar 12, 2019
When a query is translated into script terms agg where key has a date type, it should generate a terms agg with value_type long instead of date, otherwise the key gets formatted as a string, which confuses hit extractor. Fixes #37042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a query is translated into script terms agg where key has a date
type, it should generate a terms agg with value_type long instead of
date, otherwise the key gets formatted as a string, which confuses
hit extractor.
Fixes #37042