Change licence expiration date pattern #39681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to migration from joda - java licence expiration 'full date' format has to use 4-char pattern (MMMM). However since jdk9 the date with ROOT locale will still return abbreviated days and month names.
Collaborator
|
Pinging @elastic/es-core-infra |
pgomulka
changed the title
pgomulka
changed the title
tvernum
approved these changes
Mar 6, 2019
Contributor
tvernum
left a comment
tvernum
left a comment
There was a problem hiding this comment.
LGTM, but the assumeTrue message was copied incorrectly between tests.
x-pack/plugin/core/src/test/java/org/elasticsearch/license/LicenseServiceTests.java
Outdated
Show resolved
Hide resolved
…enseServiceTests.java Co-Authored-By: pgomulka <[email protected]>
Contributor
|
@pgomulka Sorry, I should have checked the labels when I reviewed this. |
Contributor
Author
|
@tvernum good idea. That probably should be backported to 7.0 too right? |
Contributor
|
Yes, |
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Mar 7, 2019
Due to migration from joda to java.time licence expiration 'full date' format has to use 4-char pattern (MMMM). Also since jdk9 the date with ROOT locale will still return abbreviated days and month names. closes elastic#39136
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Mar 7, 2019
Due to migration from joda to java.time licence expiration 'full date' format has to use 4-char pattern (MMMM). Also since jdk9 the date with ROOT locale will still return abbreviated days and month names. closes elastic#39136
This was referenced Mar 7, 2019
Contributor
|
@pgomulka I'm assuming there is nothing left to backport and removed the backport pending label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to migration from joda - java licence expiration 'full date' format
has to use 4-char pattern (MMMM). However since jdk9 the date with ROOT
locale will still return abbreviated days and month names.
closes #39136