Add roles and cluster privileges for data frame transforms #39661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds two new cluster privileges: * manage_data_frame_transforms * monitor_data_frame_transforms And two new built-in roles: * data_frame_transforms_admin * data_frame_transforms_user These permit access to the data frame transform endpoints. (Index privileges are also required on the source and destination indices for each data frame transform, but since these indices are configurable they it is not appropriate to grant them via built-in roles.)
Collaborator
|
Pinging @elastic/ml-core |
Contributor
|
In case it's not already on your to-do list, the new privileges also need to be added to Kibana: https://github.com/elastic/kibana/blob/master/x-pack/plugins/security/public/services/role_privileges.js |
hendrikmuhs
approved these changes
Mar 5, 2019
hendrikmuhs
left a comment
hendrikmuhs
left a comment
There was a problem hiding this comment.
LGTM,
just 2 small suggestions, the test failure looks real: a mismatch in the number of roles
| } | ||
|
|
||
| protected void addAuthHeaderToRequest(final Request request, final String authHeader) { | ||
| RequestOptions.Builder options = request.getOptions().toBuilder(); |
There was a problem hiding this comment.
nit: I wonder if we can make this nicer, e.g.
protected Request createRequestWithAuth (final String method, final String endpoint, final String authHeader) {
...
}
| addAuthHeaderToRequest(createDataframeTransformRequest, BASIC_AUTH_VALUE_DATA_FRAME_ADMIN_WITH_SOME_DATA_ACCESS); | ||
|
|
||
| String config = "{" | ||
| + " \"source\": \"reviews\"," |
There was a problem hiding this comment.
nit: as you were creating the constant, could be REVIEWS_INDEX_NAME
added 2 commits
March 5, 2019 11:31
droberts195
pushed a commit
that referenced
this pull request
Mar 5, 2019
This change adds two new cluster privileges: * manage_data_frame_transforms * monitor_data_frame_transforms And two new built-in roles: * data_frame_transforms_admin * data_frame_transforms_user These permit access to the data frame transform endpoints. (Index privileges are also required on the source and destination indices for each data frame transform, but since these indices are configurable they it is not appropriate to grant them via built-in roles.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds two new cluster privileges:
And two new built-in roles:
These permit access to the data frame transform endpoints.
(Index privileges are also required on the source and
destination indices for each data frame transform, but
since these indices are configurable they it is not
appropriate to grant them via built-in roles.)