Remove deprecated _time and _term sort orders #39450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated in 6.0
Collaborator
|
Pinging @elastic/es-analytics-geo |
mayya-sharipova
approved these changes
Mar 4, 2019
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
Thanks @polyfractal
Contributor
Author
|
Thanks @mayya-sharipova! We decided to just remove in 8.0, since the code change is minimal and essentially zero maintenance burden. |
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jul 5, 2021
Previously removed in elastic#39450, deprecated in es6 but not removed in es 7. defaults to _key behaviour relates elastic#51816
pgomulka
added a commit
that referenced
this pull request
Jul 6, 2021
jrodewig
added a commit
that referenced
this pull request
Sep 22, 2021
Adds an 8.0 breaking change for the removal of the `_term` and `_time` agg `order` keys. Relates to #39450
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated in 6.0, time to go :)
This isn't really a bugfix so I feel like we missed the boat on 7.0? Just target 8.0?