Skip to content

Adjust testWaitForPendingSeqNo #39404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2019
Merged

Adjust testWaitForPendingSeqNo #39404

merged 1 commit into from
Feb 26, 2019

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 26, 2019 •
edited
Loading

Since #39006, we should either remove testWaitForPendingSeqNo or adjust it not to wait for the pending operations. This change picks the latter.

Relates #39006

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. v7.0.0 v6.7.0 v8.0.0 v7.2.0 labels Feb 26, 2019
@dnhatn dnhatn requested review from jasontedor and ywelsch February 26, 2019 16:16
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 26, 2019

Pinging @elastic/es-distributed

jasontedor
jasontedor approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dnhatn
Copy link
Member Author

dnhatn commented Feb 26, 2019

Thanks @jasontedor.

@dnhatn dnhatn merged commit eae83fd into elastic:master Feb 26, 2019
@dnhatn dnhatn deleted the test_wait_for_seqno branch February 26, 2019 20:51
dnhatn added a commit that referenced this pull request Feb 26, 2019
@dnhatn
Adjust testWaitForPendingSeqNo (#39404)
a9e86bc 
Since #39006, we should either remove `testWaitForPendingSeqNo` 
or adjust it not to wait for the pending operations. This change picks 
the latter.

Relates #39006
dnhatn added a commit that referenced this pull request Feb 26, 2019
@dnhatn
Adjust testWaitForPendingSeqNo (#39404)
eff7ae8 
Since #39006, we should either remove `testWaitForPendingSeqNo` 
or adjust it not to wait for the pending operations. This change picks 
the latter.

Relates #39006
dnhatn added a commit that referenced this pull request Feb 26, 2019
@dnhatn
Adjust testWaitForPendingSeqNo (#39404)
a99e996 
Since #39006, we should either remove `testWaitForPendingSeqNo` 
or adjust it not to wait for the pending operations. This change picks 
the latter.

Relates #39006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasontedor jasontedor jasontedor approved these changes

@ywelsch ywelsch Awaiting requested review from ywelsch

Assignees

No one assigned

Labels

:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >test Issues or PRs that are addressing/adding tests v6.7.0 v7.0.0-rc1 v7.2.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dnhatn @elasticmachine @jasontedor @jakelandis @michaelbaamonde