Fix CoordinatorTests.testIncompatibleDiffResendsFullState #39345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
DaveCTurner
requested changes
Feb 25, 2019
| logger.info("--> submitting second value to {}", leader); | ||
| leader.submitValue(randomLong()); | ||
| cluster.stabilise(DEFAULT_CLUSTER_STATE_UPDATE_DELAY); | ||
| cluster.stabilise(); |
Contributor
There was a problem hiding this comment.
I think we should have an explicit duration here - we do not expect there to be an election so it should not be necessary to wait for a full stabilisation.
Contributor
Author
There was a problem hiding this comment.
Would you like to suggest such a minimal bound? The point of this test is to check the cluster state diffing logic, not determine any kind of upper bound on stabilization after a follower has been unresponsive.
Contributor
There was a problem hiding this comment.
I haven't had time to do so, and would rather merge this PR than block on that.
DaveCTurner
approved these changes
Mar 11, 2019
| logger.info("--> submitting second value to {}", leader); | ||
| leader.submitValue(randomLong()); | ||
| cluster.stabilise(DEFAULT_CLUSTER_STATE_UPDATE_DELAY); | ||
| cluster.stabilise(); |
Contributor
There was a problem hiding this comment.
I haven't had time to do so, and would rather merge this PR than block on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing since decreasing the leader and follower check timeouts (#38298). The reason is that the test was relying on the default publication timeout to come into effect before leader / follower check timeouts, which is now not always true anymore.
Closes #38867