Deprecate Hipchat Watcher actions #39160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hipchat has ceased operating, so we are deprecating Hipchat Watcher actions to be removed in Elasticsearch 7.0. This also adds a check for hipchat account settings in elasticsearch.yml. Unfortunately with the current infrastructure we can't check the watches themselves because they're in an index.
Collaborator
|
Pinging @elastic/es-core-features |
Contributor
|
@elasticmachine run elasticsearch-ci/1 There were some CI/version issues recently which should be resolved now. |
jakelandis
reviewed
Feb 20, 2019
|
|
||
| static DeprecationIssue watcherHipchatNotificationSettingsCheck(Settings nodeSettings, PluginsAndModules plugins) { | ||
| if (nodeSettings.getByPrefix("xpack.notification.hipchat.").size() > 0) { | ||
| return new DeprecationIssue(DeprecationIssue.Level.CRITICAL, |
Contributor
There was a problem hiding this comment.
I think this should be a warning since it only possibly an issue. @gwbrown - thoughts on critical vs. warning ?
Contributor
There was a problem hiding this comment.
Depends on how 7.0 behaves if you leave this setting in place. Most removed node settings are CRITICAL because Elasticsearch will refuse to start if you have unrecognized settings in elasticsearch.yml. I think that's the case here, so CRITICAL is the correct level, although I could be wrong if Watcher is doing something funny with prefix settings.
jakelandis
reviewed
Feb 20, 2019
...gin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecks.java
Show resolved
Hide resolved
jakelandis
reviewed
Feb 20, 2019
...cher/src/main/java/org/elasticsearch/xpack/watcher/actions/hipchat/HipChatActionFactory.java
Outdated
Show resolved
Hide resolved
gwbrown
reviewed
Feb 20, 2019
...gin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecks.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 20, 2019
Hipchat has been shut down and has previously been deprecated in Watcher (elastic#39160), therefore we should remove support for these actions.
dakrone
added a commit
that referenced
this pull request
Feb 25, 2019
Hipchat has been shut down and has previously been deprecated in Watcher (#39160), therefore we should remove support for these actions.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 25, 2019
Hipchat has been shut down and has previously been deprecated in Watcher (elastic#39160), therefore we should remove support for these actions.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 25, 2019
Hipchat has been shut down and has previously been deprecated in Watcher (elastic#39160), therefore we should remove support for these actions.
dakrone
added a commit
that referenced
this pull request
Feb 25, 2019
dakrone
added a commit
that referenced
this pull request
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hipchat has ceased operating, so we are deprecating Hipchat Watcher actions to
be removed in Elasticsearch 7.0.
This also adds a check for hipchat account settings in elasticsearch.yml.
Unfortunately with the current infrastructure we can't check the watches
themselves because they're in an index.