Skip to content

Fix Deadlock in HotThreadsIT #39118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix Deadlock in HotThreadsIT #39118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
698d557
Fix Deadlock in HotThreadsIT
original-brownbear Feb 19, 2019
4114114
remove unnecessary change
original-brownbear Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions server/src/test/java/org/elasticsearch/action/admin/HotThreadsIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@

public class HotThreadsIT extends ESIntegTestCase {

public void testHotThreadsDontFail() throws ExecutionException, InterruptedException {
/**
* This test just checks if nothing crashes or gets stuck etc.
*/
/**
* This test just checks if nothing crashes or gets stuck etc.
*/
public void testHotThreadsDontFail() throws InterruptedException {
createIndex("test");
final int iters = scaledRandomIntBetween(2, 20);
final AtomicBoolean hasErrors = new AtomicBoolean(false);
Expand Down Expand Up @@ -81,14 +81,15 @@ public void testHotThreadsDontFail() throws ExecutionException, InterruptedExcep
type = null;
}
final CountDownLatch latch = new CountDownLatch(1);
final int clusterNodes = cluster().size();
nodesHotThreadsRequestBuilder.execute(new ActionListener<NodesHotThreadsResponse>() {
@Override
public void onResponse(NodesHotThreadsResponse nodeHotThreads) {
boolean success = false;
try {
assertThat(nodeHotThreads, notNullValue());
Map<String, NodeHotThreads> nodesMap = nodeHotThreads.getNodesMap();
assertThat(nodesMap.size(), equalTo(cluster().size()));
assertThat(nodesMap.size(), equalTo(clusterNodes));
for (NodeHotThreads ht : nodeHotThreads.getNodes()) {
assertNotNull(ht.getHotThreads());
//logger.info(ht.getHotThreads());
Expand Down