Edits to text in Bulk API doc #39083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@elasticmachine test this please |
danielmitterdorfer
added
>docs
Collaborator
|
Pinging @elastic/es-distributed |
danielmitterdorfer
requested changes
Feb 19, 2019
Member
danielmitterdorfer
left a comment
danielmitterdorfer
left a comment
There was a problem hiding this comment.
Looks mostly fine; there is just one place where we alter the meaning now. Can you please have a look?
docs/reference/docs/bulk.asciidoc
Outdated
| === Update | ||
|
|
||
| When using `update` action `retry_on_conflict` can be used as field in | ||
| When using `update`, the action `retry_on_conflict` can be used as a field in |
Member
There was a problem hiding this comment.
In this case we're altering the meaning: retry_on_conflict is a parameter / field that can be used to influence the behavior of the update action.
dmeiss
commented
Feb 19, 2019
| === Update | ||
|
|
||
| When using `update` action `retry_on_conflict` can be used as field in | ||
| When using the `update` action, `retry_on_conflict` can be used as a field in |
Contributor
Author
There was a problem hiding this comment.
I think this fixes it -- does it look OK to you?
Member
There was a problem hiding this comment.
Looks fine to me, yes. Thank you.
Member
|
@elasticmachine test this please |
danielmitterdorfer
pushed a commit
that referenced
this pull request
Feb 20, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Feb 20, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Feb 20, 2019
danielmitterdorfer
pushed a commit
that referenced
this pull request
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor edits to text for punctuation and readability.