Fix libs:ssl-config project setup #39074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>bug
v7.0.0
:Security/Security
Collaborator
|
Pinging @elastic/es-security |
Contributor
Author
|
For elasticsearch-ci/1 https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-1/8533/console I have raised #39077 @elasticmachine run elasticsearch-ci/1 |
tvernum
approved these changes
Feb 18, 2019
albertzaharovits
added a commit
that referenced
this pull request
Feb 19, 2019
The build script file for the `:libs:elasticsearch-ssl-config` and `:libs:ssl-config-tests` projects was incorrectly named `eclipse.build.gradle` while the expected name was `eclipse-build.gradle`. In addition, this also adds a missing snippet in the `build.gradle` conf file, that fixes the project setup for Eclipse users.
albertzaharovits
added a commit
that referenced
this pull request
Feb 19, 2019
The build script file for the `:libs:elasticsearch-ssl-config` and `:libs:ssl-config-tests` projects was incorrectly named `eclipse.build.gradle` while the expected name was `eclipse-build.gradle`. In addition, this also adds a missing snippet in the `build.gradle` conf file, that fixes the project setup for Eclipse users.
Contributor
|
Thanks for looking at this @albertzaharovits . I believe this closes #38800 |
Contributor
|
/cc @colings86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a project setup for the
:libs:ssl-configproject.The build script file for the
:libs:elasticsearch-ssl-configand:libs:ssl-config-testsprojects was incorrectly namedeclipse.build.gradlewhile the expected name waseclipse-build.gradle.In addition, I added a missing snippet in the
build.gradleconf file, that fixes the project setup for Eclipse users.Looks like
:libs:ssl-config-testsare not run independently (on their own JVM), and Eclipse users (including myself) have not been bothered much by compilation issues.