Skip to content

Conversation

@hendrikmuhs
Copy link

remove array arguments for group_by

This simplifies the syntax from

"pivot": {
      "group_by": [
        {
          "reviewer": { "terms": { "field": "reviewer_id" } }
        },
...
      ],
      "aggs": {
          "avg_rating": { "avg": { "field": "rating" } }
        },
...
  }

to

"pivot": {
      "group_by": {
          "reviewer": { "terms": { "field": "reviewer_id" } }
        },
...
      "aggs": 
        {
          "avg_rating": { "avg": { "field": "rating" } }
        },
...
  }

The extra square brackets were not necessary as the inner groupings are uniquely named.

@hendrikmuhs hendrikmuhs added >feature :ml Machine learning labels Feb 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@hendrikmuhs hendrikmuhs force-pushed the feature/fib-remove-arrays-for-groups branch from e4a0043 to 8decc77 Compare February 14, 2019 13:13
@hendrikmuhs hendrikmuhs merged commit 5758a11 into elastic:feature/fib Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>feature :ml Machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants