Adapt FullClusterRestartIT on master #38856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>test
Collaborator
|
Pinging @elastic/es-search |
jtibshirani
reviewed
Feb 13, 2019
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
I noticed some other changes that fit with the goal of adapting the test for 8.0. I think it would be good to do all the updates in one PR, if that makes sense to you as well.
- We can remove
typehere, because all the calls in this method are now typeless. - We can remove all instances of
expectWarningsandallowTypesRemovalWarnings, along with associated version checks. - I think we can remove
isTypeInTemplateResponse, and the associated check. - We no longer need the special check in
extractTotalHits.
Member
Author
|
@jtibshirani thanks for the review, I agree with you to remove the deprecation warnings etc... and pushed some follow up commits for this |
Member
Author
|
As a note, I think the commit I merged in has bwc tests temporarily disabled (#38687), so I'm planning to run tests again after merging in master once again when bwc tests are enabled again. |
jtibshirani
approved these changes
Feb 14, 2019
Contributor
jtibshirani
left a comment
jtibshirani
left a comment
There was a problem hiding this comment.
This looks good to me, assuming the BWC tests pass!
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 15, 2019
* elastic/master: Avoid double term construction in DfsPhase (elastic#38716) Fix typo in DateRange docs (yyy → yyyy) (elastic#38883) Introduced class reuses follow parameter code between ShardFollowTasks (elastic#38910) Ensure random timestamps are within search boundary (elastic#38753) [CI] Muting method testFollowIndex in IndexFollowingIT Update Lucene snapshot repo for 7.0.0-beta1 (elastic#38946) SQL: Doc on syntax (identifiers in particular) (elastic#38662) Upgrade to Gradle 5.2.1 (elastic#38880) Tie break search shard iterator comparisons on cluster alias (elastic#38853) Also mmap cfs files for hybridfs (elastic#38940) Build: Fix issue with test status logging (elastic#38799) Adapt FullClusterRestartIT on master (elastic#38856) Fix testAutoFollowing test to use createLeaderIndex() helper method. Migrate muted auto follow rolling upgrade test and unmute this test (elastic#38900) ShardBulkAction ignore primary response on primary (elastic#38901) Recover peers from translog, ignoring soft deletes (elastic#38904) Fix NPE on Stale Index in IndicesService (elastic#38891) Smarter CCR concurrent file chunk fetching (elastic#38841) Fix intermittent failure in ApiKeyIntegTests (elastic#38627) re-enable SmokeTestWatcherWithSecurityIT (elastic#38814)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #38795 this PR removes a lot of special case handling that was necessary
for full cluster restart checks going from 6.x to 7.x clusters but are not required anymore going
from 7 to 8.