Add documentation about breaking java time changes #38720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spinscale
added
>docs
Collaborator
|
Pinging @elastic/es-core-infra |
Member
danielmitterdorfer
left a comment
danielmitterdorfer
left a comment
There was a problem hiding this comment.
I think it makes sense to document those changes in a separate file. I left a few suggestions.
Contributor
Author
|
took care of all your comments. I also grepped through the whole documentation and removed any mentions of joda time or joda specific formats in another commit within this PR |
danielmitterdorfer
approved these changes
Feb 13, 2019
Member
danielmitterdorfer
left a comment
danielmitterdorfer
left a comment
There was a problem hiding this comment.
Thanks for iterating, this looks great. I left only very minor comments (which won't require another review round). LGTM
spinscale
added a commit
to spinscale/elasticsearch
that referenced
this pull request
Feb 14, 2019
In addition remove joda time mentions across the docs, make sure links are updated to java time javadocs.
spinscale
added a commit
to spinscale/elasticsearch
that referenced
this pull request
Feb 14, 2019
In addition remove joda time mentions across the docs, make sure links are updated to java time javadocs.
spinscale
added a commit
that referenced
this pull request
Feb 14, 2019
In addition remove joda time mentions across the docs, make sure links are updated to java time javadocs. Forward port of #38720
spinscale
added a commit
that referenced
this pull request
Feb 14, 2019
This is the forward port of #38720 (not containing the 7.0 migration docs)
Member
|
@spinscale This should probably be partially backported to 6.7? |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 14, 2019
* elastic/master: Remove immediate operation retry after mapping update (elastic#38873) Remove mentioning of types from bulk API docs (elastic#38896) SQL: change JDBC setup URL in the documentation (elastic#38564) Skip BWC tests in checkPart1 and checkPart2 (elastic#38730) Enable silent FollowersCheckerTest (elastic#38851) Update TESTING.asciidoc with platform specific instructions (elastic#38802) Use consistent view of realms for authentication (elastic#38815) Stabilize RareClusterState (elastic#38671) Increase Timeout in UnicastZenPingTests (elastic#38893) Do not recommend installing vagrant-winrm elastic#38887 _cat/indices with Security, hide names when wildcard (elastic#38824) SQL: fall back to using the field name for column label (elastic#38842) Fix LocalIndexFollowingIT#testRemoveRemoteConnection() test (elastic#38709) Remove joda time mentions in documentation (elastic#38720) Add enabled status for token and api key service (elastic#38687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation for changes regarding the joda/java time switch.