Make qa/full-cluster-restart tests pass. By fixing a helper method and #38604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muting a test. Relates to elastic#38603
martijnvg
added
>non-issue
>test
martijnvg
commented
Feb 8, 2019
| Request request = new Request("GET", "/info/" + this.type + "/" + index + "_" + type); | ||
| request.addParameter("filter_path", "_source"); | ||
| if (isRunningAgainstAncientCluster()) { | ||
| if (getOldClusterVersion().before(Version.V_6_7_0)) { |
Member
Author
There was a problem hiding this comment.
Whether a warning is expected, depends on whether type doc in this.type is used and that depends on whether the old cluster was before 6.7.0
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 8, 2019
* 7.x: Make qa/full-cluster-restart tests pass. By fixing a helper method and (elastic#38604) Mute failing WatchStatusIntegrationTests (elastic#38621) Mute failing ApiKeyIntegTests (elastic#38614) [DOCS] Add warning about bypassing ML PUT APIs (elastic#38605) Mute RetentionLeastIT.testRetentionLeasesSyncOnRecovery on 7x (elastic#38597) Only "include_type_name" if running on >= 7 (elastic#38594) Fix version logic when bumping major version (elastic#38593)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
muting a test.
Relates to #38603