Fix build on Fips #38546
Merged
Fix build on Fips #38546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testing convetions need to be disabled if the test task is for fips.
andyb-elastic
added
>test
Collaborator
|
Pinging @elastic/es-security |
jkakavas
approved these changes
Feb 7, 2019
Contributor
jkakavas
left a comment
jkakavas
left a comment
There was a problem hiding this comment.
LGTM Andy, thanks for taking care of this
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 8, 2019
* 6.7: Fix build on Fips (elastic#38546) ML: update set_upgrade_mode, add logging (elastic#38372) (elastic#38539) Update 'removal of types' docs to reflect the new plan. (elastic#38548) Make the 'get templates' types deprecation message consistent. (elastic#38532) Add API key settings documentation (elastic#38490) (elastic#38499) Mute testExpiredApiKeysDeletedAfter1Week in 6.7 (elastic#38528)
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 11, 2019
* This is currently failing with: ``` Test classes are not included in any enabled task (:modules:reindex:test): * org.elasticsearch.client.documentation.ReindexDocumentationIT * org.elasticsearch.index.reindex.ManyDocumentsIT * org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT * org.elasticsearch.index.reindex.ReindexWithoutContentIT * org.elasticsearch.index.reindex.remote.ReindexFromOldRemoteIT ``` * Same fix as in elastic#38546
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 11, 2019
* This is currently failing with: ``` Test classes are not included in any enabled task (:modules:reindex:test): * org.elasticsearch.client.documentation.ReindexDocumentationIT * org.elasticsearch.index.reindex.ManyDocumentsIT * org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT * org.elasticsearch.index.reindex.ReindexWithoutContentIT * org.elasticsearch.index.reindex.remote.ReindexFromOldRemoteIT ``` * Same fix as in elastic#38546
original-brownbear
added a commit
that referenced
this pull request
Apr 11, 2019
* This is currently failing with: ``` Test classes are not included in any enabled task (:modules:reindex:test): * org.elasticsearch.client.documentation.ReindexDocumentationIT * org.elasticsearch.index.reindex.ManyDocumentsIT * org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT * org.elasticsearch.index.reindex.ReindexWithoutContentIT * org.elasticsearch.index.reindex.remote.ReindexFromOldRemoteIT ``` * Same fix as in #38546
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* This is currently failing with: ``` Test classes are not included in any enabled task (:modules:reindex:test): * org.elasticsearch.client.documentation.ReindexDocumentationIT * org.elasticsearch.index.reindex.ManyDocumentsIT * org.elasticsearch.index.reindex.ReindexClientYamlTestSuiteIT * org.elasticsearch.index.reindex.ReindexWithoutContentIT * org.elasticsearch.index.reindex.remote.ReindexFromOldRemoteIT ``` * Same fix as in elastic#38546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testing convetions need to be disabled if the test task is for fips.
This is a cherry-pick of 6a5f3f0 which fixed this on master. This was failing on 6.x and so now fails on 6.7
Closes #38322 and #37697