Fix the clock resolution to millis in ScheduledEventTests #38516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) The clock resolution changed from jdk8 to jdk10, hence the test is passing in jdk8 but failing in jdk10. Scheduled events are serialised and deserialised with millisecond precision, making test fail in jdk 10 and higher. Fixes a problem introduced by elastic#38415 and the fix is identical to the one that was made in elastic#38405.
Collaborator
|
Pinging @elastic/ml-core |
droberts195
changed the title
Author
|
Closing, as the change was incorporated in #38513, so the change is in the 7.x branch via that PR |
droberts195
deleted the
millisecond_accuracy_for_scheduled_event_tests_7x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clock resolution changed from jdk8 to jdk10, hence the
test is passing in jdk8 but failing in jdk10. Scheduled
events are serialised and deserialised with millisecond
precision, making test fail in jdk 10 and higher.
Fixes a problem introduced by #38415 and the fix is
identical to the one that was made in #38405.
Backport of #38506